hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9996) move the log io operation out of updateLock scope
Date Tue, 19 Nov 2013 13:05:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826474#comment-13826474
] 

Hadoop QA commented on HBASE-9996:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12614578/HBase-9996-0.94.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7930//console

This message is automatically generated.

> move the log io operation out of updateLock scope
> -------------------------------------------------
>
>                 Key: HBASE-9996
>                 URL: https://issues.apache.org/jira/browse/HBASE-9996
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.94.13
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HBase-9996-0.94.txt
>
>
> I am working at another write outlier issue, and just saw this code pattern:
> {code}
> synchronized(updateLock) {
> ...
> LOG.info(xxx)
> ...
> }
> {code}
> let's move the log statement out of this sync block.  seems it's ok in trunk code, just
a 0.94 issue



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message