hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-9962) Improve tag iteration
Date Wed, 13 Nov 2013 00:29:17 GMT

     [ https://issues.apache.org/jira/browse/HBASE-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-9962:
----------------------------------

    Description: The tag iterator was moved out of KeyValue into CellUtil and marked as for
tests only. HBASE-7662 and HBASE-7663 will use it. The 'length' parameter was made into a
short, which is inconvenient for most callers. The methods on Tag for getting tag data offset
and length in the tag buffer were made default scope so it's impossible outside of the package
to find the tag data in the backing buffer without calling Tag#asList, which might do some
unwanted object allocations. Tags#asList also inconveniently uses short for 'length'.  (was:
The tag iterator was moved out of KeyValue into CellUtil and marked as for tests only. HBASE-7662
and HBASE-7663 will use it. The 'length' parameter was made into a short, which is inconvenient
for most callers. The methods on KeyValue.Tag for getting tag data offset and length in the
tag buffer were made default scope so it's impossible outside of the package to find the tag
data in the backing buffer without calling Tag#asList, which might do some unwanted object
allocations. Tags#asList also inconveniently uses short for 'length'.)

> Improve tag iteration
> ---------------------
>
>                 Key: HBASE-9962
>                 URL: https://issues.apache.org/jira/browse/HBASE-9962
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.0
>
>         Attachments: 9962.patch
>
>
> The tag iterator was moved out of KeyValue into CellUtil and marked as for tests only.
HBASE-7662 and HBASE-7663 will use it. The 'length' parameter was made into a short, which
is inconvenient for most callers. The methods on Tag for getting tag data offset and length
in the tag buffer were made default scope so it's impossible outside of the package to find
the tag data in the backing buffer without calling Tag#asList, which might do some unwanted
object allocations. Tags#asList also inconveniently uses short for 'length'.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message