hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9958) Remove some array copy, change lock scope in locateRegion
Date Tue, 12 Nov 2013 17:21:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820266#comment-13820266
] 

Nick Dimiduk commented on HBASE-9958:
-------------------------------------

Nit: this can now throw an NPE where previously it returned null.

{noformat}
   public static HRegionInfo parseFromOrNull(final byte [] bytes) {
-    if (bytes == null || bytes.length <= 0) return null;
+    return parseFromOrNull(bytes, 0, bytes.length);
+  }
{noformat}

What a difference 14k makes ;)

+1

> Remove some array copy, change lock scope in locateRegion
> ---------------------------------------------------------
>
>                 Key: HBASE-9958
>                 URL: https://issues.apache.org/jira/browse/HBASE-9958
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9958.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message