hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9909) TestHFilePerformance should not be a unit test, but a tool
Date Thu, 07 Nov 2013 02:51:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815584#comment-13815584

Jean-Marc Spaggiari commented on HBASE-9909:

bq. Looked at those, it seems these are slightly different. TestHFilePerformance is more focussed
on perf for seq writes and reads between hfile and seq file. 

Should they be merged then? I guess you will say yes, but on a separate JIRA? ;)

Opened HBASE-9910 and  HBASE-9911.

> TestHFilePerformance should not be a unit test, but a tool
> ----------------------------------------------------------
>                 Key: HBASE-9909
>                 URL: https://issues.apache.org/jira/browse/HBASE-9909
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.96.1
>         Attachments: hbase-9909_v1.patch
> TestHFilePerformance is a very old test, which does not test anything, but a perf evaluation
tool. It is not clear to me whether there is any utility for keeping it, but that should at
least be converted to be a tool. 
> Note that TestHFile already covers the unit test cases (writing hfile with none and gz
compression). We do not need to test SequenceFile. 

This message was sent by Atlassian JIRA

View raw message