hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9902) Region Server is starting normally even if clock skew is more than default 30 seconds(or any configured). -> Regionserver node time is greater than master node time
Date Mon, 11 Nov 2013 11:43:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13818885#comment-13818885
] 

Hadoop QA commented on HBASE-9902:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12613138/HBASE-9902_v2-0.94.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7810//console

This message is automatically generated.

> Region Server is starting normally even if clock skew is more than default 30 seconds(or
any configured). -> Regionserver node time is greater than master node time
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9902
>                 URL: https://issues.apache.org/jira/browse/HBASE-9902
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.94.11
>            Reporter: Kashif J S
>            Assignee: Kashif J S
>             Fix For: 0.98.0, 0.96.1, 0.94.14
>
>         Attachments: HBASE-9902.patch, HBASE-9902_v2-0.94.patch, HBASE-9902_v2.patch
>
>
> When Region server's time is ahead of Master's time and the difference is more than hbase.master.maxclockskew
value, region server startup is not failing with ClockOutOfSyncException.
> This causes some abnormal behavior as detected by our Tests.
>     ServerManager.java#checkClockSkew
>           long skew = System.currentTimeMillis() - serverCurrentTime;
>         if (skew > maxSkew) {
>           String message = "Server " + serverName + " has been " +
>             "rejected; Reported time is too far out of sync with master.  " +
>             "Time difference of " + skew + "ms > max allowed of " + maxSkew + "ms";
>           LOG.warn(message);
>           throw new ClockOutOfSyncException(message);
>         }
>     Above line results in negative value when Master's time is lesser than region server
time and  " if (skew > maxSkew) " check fails to find the skew in this case.
>     Please Note: This was tested in hbase 0.94.11 version and the trunk also currently
has the same logic.
> The fix for the same would be to make the skew positive value first as below:
>  long skew = System.currentTimeMillis() - serverCurrentTime;
>     skew = (skew < 0 ? -skew : skew);
>     if (skew > maxSkew) {.....



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message