hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9893) Incorrect assert condition in OrderedBytes decoding
Date Wed, 20 Nov 2013 11:40:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827574#comment-13827574
] 

Hudson commented on HBASE-9893:
-------------------------------

SUCCESS: Integrated in hbase-0.96-hadoop2 #125 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/125/])
HBASE-9893 Incorrect assert condition in OrderedBytes decoding

Correct an invalid assumption in remaining assertion code around
OrderedBytes#decodeVarBlob. When an encoded value contains a 1-bit in its LSB
position and the length of the encoded byte array is divisible by 7, the value
remaining in variable t will be 0x80, resulting in the failed assertion coming
out of the decoding loop. This patch preserves the assertion for the general
case by resetting 't' at the conclusion of the 7-byte cycle. (ndimiduk: rev 1543700)
* /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/util/OrderedBytes.java
* /hbase/branches/0.96/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestOrderedBytes.java


> Incorrect assert condition in OrderedBytes decoding
> ---------------------------------------------------
>
>                 Key: HBASE-9893
>                 URL: https://issues.apache.org/jira/browse/HBASE-9893
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.96.0
>            Reporter: He Liangliang
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: HBASE-9893.00-1.patch, HBASE-9893.00.patch, HBASE-9893.patch
>
>
> The following assert condition is incorrect when decoding blob var byte array.
> {code}
>     assert t == 0 : "Unexpected bits remaining after decoding blob.";
> {code}
> When the number of bytes to decode is multiples of 8 (i.e the original number of bytes
is multiples of 7), this assert may fail.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message