hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-9870) HFileDataBlockEncoderImpl#diskToCacheFormat uses wrong format
Date Wed, 13 Nov 2013 17:37:22 GMT

     [ https://issues.apache.org/jira/browse/HBASE-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jimmy Xiang updated HBASE-9870:
-------------------------------

      Resolution: Fixed
    Release Note: The patch makes sure that data block encoding in cache is always the same
as that on disk. It deprecates the column family attribute ENCODE_ON_DISK since it doesn't
apply any more. HColumnDescriptor#setEncodeOnDisk(boolean) is still there for compatibility
issue. However, it doesn't do anything now. HColumnDescriptor#getDataBlockEncodingOnDisk()
is also deprecated because the data block encoding on disk is always the same as that in cache
for a given store file.  (was: The patch makes sure that data block encoding in cache is always
the same as that on disk. It deprecates the column family attribute ENCODE_ON_DISK since it
doesn't apply any more.)
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

Integrated into trunk and 0.96. Thanks.

> HFileDataBlockEncoderImpl#diskToCacheFormat uses wrong format
> -------------------------------------------------------------
>
>                 Key: HBASE-9870
>                 URL: https://issues.apache.org/jira/browse/HBASE-9870
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: trunk-9870.patch, trunk-9870_v2.patch, trunk-9870_v3.patch
>
>
> In this method, we have
> {code}
>     if (block.getBlockType() == BlockType.ENCODED_DATA) {
>       if (block.getDataBlockEncodingId() == onDisk.getId()) {
>         // The block is already in the desired in-cache encoding.
>         return block;
>       }
> {code}
> This assumes onDisk encoding is the same as that of inCache.  This is not true when we
change the encoding of a CF.  This could be one of the reasons I got data loss with online
encoding change?
> If I make sure onDisk == inCache all the time, my ITBLL with online encoding change worked
once for me.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message