hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9869) Optimize HConnectionManager#getCachedLocation
Date Sun, 17 Nov 2013 10:41:23 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824800#comment-13824800

Nicolas Liochon commented on HBASE-9869:

bq.  You opened an issue on interning TableNames. That patch looks good. 
I'm still on this one, to understand why the performances varied, and looking for the best
solution. For example, the tableName is already in the regionName of the HRegionInfo. May
be HRegionInfo should not have a reference to the TableName object, we don't need it that

bq. We should open another for ServerName? Makes sense.
I still on this one as well :-). It's more complex, because the number of serverName is theoretically
unbounded, as it includes a startCode.

I've just committed the v4. I'm quite happy to have this part done...

> Optimize HConnectionManager#getCachedLocation
> ---------------------------------------------
>                 Key: HBASE-9869
>                 URL: https://issues.apache.org/jira/browse/HBASE-9869
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>         Attachments: 6869.v4.patch, 9869.v1.patch, 9869.v1.patch, 9869.v2.patch
> It javadoc says: "TODO: This method during writing consumes 15% of CPU doing lookup".
This is still true, says Yourkit. With 0.96, we also spend more time in these methods. We
retry more, and the AsyncProcess calls it in parallel.
> I don't have the patch for this yet, but I will spend some time on it.

This message was sent by Atlassian JIRA

View raw message