hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9867) Save on array copies with a subclass of LiteralByteString
Date Tue, 05 Nov 2013 01:10:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813508#comment-13813508

Hudson commented on HBASE-9867:

FAILURE: Integrated in hbase-0.96 #179 (See [https://builds.apache.org/job/hbase-0.96/179/])
HBASE-9880 client.TestAsyncProcess.testWithNoClearOnFail broke on 0.96 by HBASE-9867 (nkeywal:
rev 1538676)
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java

> Save on array copies with a subclass of LiteralByteString
> ---------------------------------------------------------
>                 Key: HBASE-9867
>                 URL: https://issues.apache.org/jira/browse/HBASE-9867
>             Project: HBase
>          Issue Type: Improvement
>          Components: Protobufs
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.98.0, 0.96.1
>         Attachments: 9867.096.txt, 9867.txt, 9867.txt, 9867v2.txt
> Any time we add a byte array to a protobuf, it'll copy the byte array.
> I was playing with the client and noticed how a bunch of CPU and copying was being done
just to copy basic arrays doing pb construction.  I started to look at ByteString and then
remembered a class Benoit sent me a while back that I did not understand from his new AsyncHBase.
 After looking in ByteString it made now sense.  So, rather than copy byte arrays everywhere,
do a version of a ByteString that instead wraps the array.

This message was sent by Atlassian JIRA

View raw message