hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-9489) Add cp hooks in online merge before and after setting PONR
Date Sat, 30 Nov 2013 06:22:37 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835628#comment-13835628
] 

Anoop Sam John edited comment on HBASE-9489 at 11/30/13 6:22 AM:
-----------------------------------------------------------------

1. There are some white spaces in the patch. Pls make sure you remove it on commit

2. postMergeCommit -> 
bq. +   * Calling {@link org.apache.hadoop.hbase.coprocessor.ObserverContext#bypass()} has
no effect
No need to add this in javadoc. Normally there is no impact on bypass on post hooks. It is
post operation.

3. preRollBackMerge ->
bq. +   * This will be called before the roll back of the regions merge is completed
The statement is not so clear. Why say "is completed"? 
"This will be called before the rollback of regions merge" Is that enough?
Same with postRollBackMerge doc also.

4. preMergeCommit ->
bq. +   * @param metaEntries
Can you add some notes about the use of this param. How the CP can use this?


was (Author: anoop.hbase):
1. There are some white spaces in the patch. Pls make sure you remove it on commit

2. postMergeCommit -> 
+   * Calling {@link org.apache.hadoop.hbase.coprocessor.ObserverContext#bypass()} has no
effect
No need to add this in javadoc. Normally there is no impact on bypass on post hooks. It is
post operation.

3. preRollBackMerge ->
+   * This will be called before the roll back of the regions merge is completed
The statement is not so clear. Why say "is completed"? 
"This will be called before the rollback of regions merge" Is that enough?
Same with postRollBackMerge doc also.

4. preMergeCommit ->
+   * @param metaEntries
Can you add some notes about the use of this param. How the CP can use this?

> Add cp hooks in online merge before and after setting PONR
> ----------------------------------------------------------
>
>                 Key: HBASE-9489
>                 URL: https://issues.apache.org/jira/browse/HBASE-9489
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>         Attachments: HBASE-9489.patch, HBASE-9489_v2.patch, HBASE-9489_v3.patch
>
>
> As we need to merge index region along with user region we need the hooks before and
after setting PONR in region merge transtion.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message