hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-8075) HRegion preClose hook is getting called multiple times for single close
Date Wed, 27 Nov 2013 00:08:36 GMT

     [ https://issues.apache.org/jira/browse/HBASE-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Purtell updated HBASE-8075:
----------------------------------

    Issue Type: Bug  (was: Sub-task)
        Parent:     (was: HBASE-9945)

> HRegion preClose hook is getting called multiple times for single close
> -----------------------------------------------------------------------
>
>                 Key: HBASE-8075
>                 URL: https://issues.apache.org/jira/browse/HBASE-8075
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>            Reporter: rajeshbabu
>
> 1) HRegionServer#closeRegion(final RpcController controller,
>       final CloseRegionRequest request)
> {code}
>       // Can be null if we're calling close on a region that's not online
>       final HRegion region = this.getFromOnlineRegions(encodedRegionName);
>       if ((region  != null) && (region .getCoprocessorHost() != null)) {
>         region.getCoprocessorHost().preClose(false);
>       }
> {code}
> 2) HRegionServer#closeRegion(String encodedName, final boolean abort,
>       final boolean zk, final int versionOfClosingNode, final ServerName sn)
> {code}
>     if ((actualRegion != null) && (actualRegion.getCoprocessorHost() != null))
{
>       try {
>         actualRegion.getCoprocessorHost().preClose(false);
>       } catch (IOException exp) {
>         LOG.warn("Unable to close region: the coprocessor launched an error ", exp);
>         return false;
>       }
>     }
> {code}
> 3) HRegion#  private List<StoreFile> doClose(
>       final boolean abort, MonitoredTask status)
> {code}
>     if (coprocessorHost != null) {
>       status.setStatus("Running coprocessor pre-close hooks");
>       this.coprocessorHost.preClose(abort);
>     }
> {code}
> IMO 3rd one is enough and remaining two are not needed.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message