Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E9809100DD for ; Thu, 31 Oct 2013 15:41:22 +0000 (UTC) Received: (qmail 18550 invoked by uid 500); 31 Oct 2013 15:41:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 18525 invoked by uid 500); 31 Oct 2013 15:41:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 18516 invoked by uid 99); 31 Oct 2013 15:41:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Oct 2013 15:41:22 +0000 Date: Thu, 31 Oct 2013 15:41:22 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-9867) Save on array copies with a subclass of LiteralByteString MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-9867: ------------------------- Attachment: 9867.txt Retry > Save on array copies with a subclass of LiteralByteString > --------------------------------------------------------- > > Key: HBASE-9867 > URL: https://issues.apache.org/jira/browse/HBASE-9867 > Project: HBase > Issue Type: Improvement > Components: Protobufs > Affects Versions: 0.96.0 > Reporter: stack > Assignee: stack > Fix For: 0.98.0, 0.96.1 > > Attachments: 9867.txt, 9867.txt > > > Any time we add a byte array to a protobuf, it'll copy the byte array. > I was playing with the client and noticed how a bunch of CPU and copying was being done just to copy basic arrays doing pb construction. I started to look at ByteString and then remembered a class Benoit sent me a while back that I did not understand from his new AsyncHBase. After looking in ByteString it made now sense. So, rather than copy byte arrays everywhere, do a version of a ByteString that instead wraps the array. -- This message was sent by Atlassian JIRA (v6.1#6144)