Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BF77110092 for ; Tue, 15 Oct 2013 07:41:50 +0000 (UTC) Received: (qmail 88468 invoked by uid 500); 15 Oct 2013 07:41:45 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 88423 invoked by uid 500); 15 Oct 2013 07:41:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88399 invoked by uid 99); 15 Oct 2013 07:41:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2013 07:41:42 +0000 Date: Tue, 15 Oct 2013 07:41:42 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HBASE-9761) Put copy constructor should clone the operation attributes also MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794964#comment-13794964 ] ramkrishna.s.vasudevan edited comment on HBASE-9761 at 10/15/13 7:39 AM: ------------------------------------------------------------------------- Just check for null and then add the code {code} + for (Map.Entry entry : putToCopy.getAttributesMap().entrySet()) { + this.setAttribute(entry.getKey(), entry.getValue()); + } {code} {Edit} Not needed. Internally it returns an empty map. So +1 stands. {Edit} was (Author: ram_krish): Just check for null and then add the code {code} + for (Map.Entry entry : putToCopy.getAttributesMap().entrySet()) { + this.setAttribute(entry.getKey(), entry.getValue()); + } {code} > Put copy constructor should clone the operation attributes also > --------------------------------------------------------------- > > Key: HBASE-9761 > URL: https://issues.apache.org/jira/browse/HBASE-9761 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.98.0, 0.95.2, 0.94.12, 0.96.0 > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Attachments: HBASE-9761_Trunk.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)