Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E4AC10A38 for ; Mon, 14 Oct 2013 13:04:47 +0000 (UTC) Received: (qmail 7759 invoked by uid 500); 14 Oct 2013 13:04:45 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 7649 invoked by uid 500); 14 Oct 2013 13:04:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 7455 invoked by uid 99); 14 Oct 2013 13:04:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Oct 2013 13:04:42 +0000 Date: Mon, 14 Oct 2013 13:04:42 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9751) Excessive readpoints checks in StoreFileScanner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794093#comment-13794093 ] Hudson commented on HBASE-9751: ------------------------------- SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #792 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/792/]) HBASE-9751 Excessive readpoints checks in StoreFileScanner (larsh: rev 1531790) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java > Excessive readpoints checks in StoreFileScanner > ------------------------------------------------ > > Key: HBASE-9751 > URL: https://issues.apache.org/jira/browse/HBASE-9751 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.0, 0.94.12, 0.96.0 > Reporter: Vladimir Rodionov > Assignee: Lars Hofhansl > Fix For: 0.98.0, 0.94.13, 0.96.1 > > Attachments: 9751-0.94.txt, 9751-0.94-v2.txt, 9751-trunk.txt, 9751-trunk-v2.txt > > > It seems that usage of skipKVsNewerThanReadpoint in StoreFileScanner can be greatly reduced or even eliminated all together (HFiles are immutable and no new KVs can be inserted after scanner instance is created). The same is true for MemStoreScanner which checks readpoint on every next() and seek(). Each readpoint check is ThreadLocal.get() and it is quite expensive. -- This message was sent by Atlassian JIRA (v6.1#6144)