Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9AD1A10717 for ; Fri, 4 Oct 2013 17:03:43 +0000 (UTC) Received: (qmail 74391 invoked by uid 500); 4 Oct 2013 17:03:43 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 74176 invoked by uid 500); 4 Oct 2013 17:03:43 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74139 invoked by uid 99); 4 Oct 2013 17:03:42 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Oct 2013 17:03:42 +0000 Date: Fri, 4 Oct 2013 17:03:42 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9612) Ability to batch edits destined to different regions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9612?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1378= 6333#comment-13786333 ]=20 stack commented on HBASE-9612: ------------------------------ What you think of these failure [~nkeywal] ? You able to fix? I've been w= orking on patch since early morning... almost done.. .but let me look at yo= urs (From our text discussions, yours sounds better than mine). > Ability to batch edits destined to different regions > ---------------------------------------------------- > > Key: HBASE-9612 > URL: https://issues.apache.org/jira/browse/HBASE-9612 > Project: HBase > Issue Type: Bug > Affects Versions: 0.95.0, 0.95.1, 0.95.2, 0.96.0 > Reporter: Benoit Sigoure > Assignee: stack > Priority: Critical > Fix For: 0.98.0, 0.96.0 > > Attachments: 0001-fix-packaging-by-region-in-MultiServerCallable.= patch, 9612.096.v5.txt, 9612revert.txt, 9612-v10-nico.patch, 9612v10.txt, 9= 612-v11-nico.patch, 9612v11.txt, 9612v12.txt, 9612v2.txt, 9612v3.txt, 9612v= 4.txt, 9612v5.txt, 9612v5.txt, 9612v5.txt, 9612v7.txt, 9612v8.096.txt, 9612= v8.txt, 9612v9.txt, 9612v9.txt, 9612.wip.txt > > > The old (pre-PB) "multi" and "multiPut" RPCs allowed one to batch edits d= estined to different regions. Seems like we've lost this ability after the= switch to protobufs. > The {{MultiRequest}} only contains one {{RegionSpecifier}}, and a list of= {{MultiAction}}. The {{MultiAction}} message is contains either a single = {{MutationProto}} or a {{Get}} (but not both =E2=80=93 so its name is misle= ading as there is nothing "multi" about it). Also it seems redundant with = {{MultiGetRequest}}, I'm not sure what's the point of supporting {{Get}} in= {{MultiAction}}. > I propose that we change {{MultiRequest}} to be a just a list of {{MultiA= ction}}, and {{MultiAction}} will contain the {{RegionSpecifier}}, the {{bo= ol atomic}} and a list of {{MutationProto}}. This would be a non-backward = compatible protobuf change. > If we want we can support mixing edits and reads, in which case we'd also= add a list of {{Get}} in {{MultiAction}}, and we'd have support having bot= h that list and the list of {{MutationProto}} set at the same time. But th= is is a bonus and can be done later (in a backward compatible manner, hence= no need to rush on this one). -- This message was sent by Atlassian JIRA (v6.1#6144)