Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 4 Oct 2013 14:35:42 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12669842.1379816999109.13954.1380897342257@arcas>
In-Reply-To: <JIRA.12669842.1379816999109@arcas>
References: <JIRA.12669842.1379816999109@arcas>
Subject: [jira] [Commented] (HBASE-9612) Ability to batch edits destined to
 different regions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HBASE-9612?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1378=
6192#comment-13786192 ]=20

Hadoop QA commented on HBASE-9612:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest a=
ttachment=20
  http://issues.apache.org/jira/secure/attachment/12606779/9612-v10-nico.pa=
tch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author=
 tags.

    {color:green}+1 tests included{color}.  The patch appears to include 18=
 new or modified tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoo=
p 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoo=
p 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any =
warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the =
total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new =
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not incre=
ase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines=
 longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to=
 fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.cleaner.TestSnapshotF=
romMaster
                  org.apache.hadoop.hbase.security.access.TestAccessControl=
ler
                  org.apache.hadoop.hbase.regionserver.TestRegionServerMetr=
ics
                  org.apache.hadoop.hbase.coprocessor.TestRegionObserverInt=
erface

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7465//tes=
tReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.htm=
l
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.=
html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7465=
//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.h=
tml
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7465//c=
onsole

This message is automatically generated.

> Ability to batch edits destined to different regions
> ----------------------------------------------------
>
>                 Key: HBASE-9612
>                 URL: https://issues.apache.org/jira/browse/HBASE-9612
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0, 0.95.1, 0.95.2, 0.96.0
>            Reporter: Benoit Sigoure
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.98.0, 0.96.0
>
>         Attachments: 0001-fix-packaging-by-region-in-MultiServerCallable.=
patch, 9612.096.v5.txt, 9612revert.txt, 9612-v10-nico.patch, 9612v10.txt, 9=
612v11.txt, 9612v12.txt, 9612v2.txt, 9612v3.txt, 9612v4.txt, 9612v5.txt, 96=
12v5.txt, 9612v5.txt, 9612v7.txt, 9612v8.096.txt, 9612v8.txt, 9612v9.txt, 9=
612v9.txt, 9612.wip.txt
>
>
> The old (pre-PB) "multi" and "multiPut" RPCs allowed one to batch edits d=
estined to different regions.  Seems like we've lost this ability after the=
 switch to protobufs.
> The {{MultiRequest}} only contains one {{RegionSpecifier}}, and a list of=
 {{MultiAction}}.  The {{MultiAction}} message is contains either a single =
{{MutationProto}} or a {{Get}} (but not both =E2=80=93 so its name is misle=
ading as there is nothing "multi" about it).  Also it seems redundant with =
{{MultiGetRequest}}, I'm not sure what's the point of supporting {{Get}} in=
 {{MultiAction}}.
> I propose that we change {{MultiRequest}} to be a just a list of {{MultiA=
ction}}, and {{MultiAction}} will contain the {{RegionSpecifier}}, the {{bo=
ol atomic}} and a list of {{MutationProto}}.  This would be a non-backward =
compatible protobuf change.
> If we want we can support mixing edits and reads, in which case we'd also=
 add a list of {{Get}} in {{MultiAction}}, and we'd have support having bot=
h that list and the list of {{MutationProto}} set at the same time.  But th=
is is a bonus and can be done later (in a backward compatible manner, hence=
 no need to rush on this one).


--
This message was sent by Atlassian JIRA
(v6.1#6144)