hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9868) Remove some array copy, especially around protobuf
Date Thu, 31 Oct 2013 17:07:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810434#comment-13810434
] 

stack commented on HBASE-9868:
------------------------------

Patch looks good.  This stuff will clash w/ the patch over in HBASE-9867 (and I think what
is in 9867 is 'safer' -- but that we should probably add a byte array, offset, length op too)

-          valueBuilder.setQualifier(ByteString.copyFrom(kv.getQualifier()));
-          valueBuilder.setValue(ByteString.copyFrom(kv.getValue()));
+          valueBuilder.setQualifier(ByteString.copyFrom(
+              kv.getQualifierArray(), kv.getQualifierOffset(), kv.getQualifierLength()));
+          valueBuilder.setValue(ByteString.copyFrom(
+              kv.getValueArray(), kv.getValueOffset(), kv.getValueLength()));




> Remove some array copy, especially around protobuf
> --------------------------------------------------
>
>                 Key: HBASE-9868
>                 URL: https://issues.apache.org/jira/browse/HBASE-9868
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, Protobufs
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9868.v1.patch
>
>
> Profiling the client shows that we're spending some time in array copy (10% of the code
execution, 3% of the total time) in some array copy that we can avoid.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message