hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9867) Save on array copies with a subclass of LiteralByteString
Date Thu, 31 Oct 2013 19:07:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810566#comment-13810566
] 

stack commented on HBASE-9867:
------------------------------

[~jeffreyz] LBS is package private to com.google.protobuf so I don't think we can do your
suggestion of LBS in ProtobufUtil (IIUUC).   Let me make your other suggested change.  Makes
sense.  Let me fix javadoc and findbugs warnings too.  Thanks for review.

> Save on array copies with a subclass of LiteralByteString
> ---------------------------------------------------------
>
>                 Key: HBASE-9867
>                 URL: https://issues.apache.org/jira/browse/HBASE-9867
>             Project: HBase
>          Issue Type: Improvement
>          Components: Protobufs
>    Affects Versions: 0.96.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9867.txt, 9867.txt
>
>
> Any time we add a byte array to a protobuf, it'll copy the byte array.
> I was playing with the client and noticed how a bunch of CPU and copying was being done
just to copy basic arrays doing pb construction.  I started to look at ByteString and then
remembered a class Benoit sent me a while back that I did not understand from his new AsyncHBase.
 After looking in ByteString it made now sense.  So, rather than copy byte arrays everywhere,
do a version of a ByteString that instead wraps the array.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message