hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9807) scanning with block encoding unnecessarily copies the key for each reseek
Date Sun, 20 Oct 2013 06:17:43 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800091#comment-13800091
] 

Lars Hofhansl commented on HBASE-9807:
--------------------------------------

This is just the default implementation, overridden in ScannerV2 and EncodedScannerV2. I don't
think I even need this. This won't be called on ScannerV1 (in 0.94) and could just throw UnsupportedOperationException.

> scanning with block encoding unnecessarily copies the key for each reseek
> -------------------------------------------------------------------------
>
>                 Key: HBASE-9807
>                 URL: https://issues.apache.org/jira/browse/HBASE-9807
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>         Attachments: 9807-0.94.txt
>
>
> In HFileReaderV2.AbstractScannerV2.reseekTo(...) we have this:
> {code}
>         ByteBuffer bb = getKey();
>         compared = reader.getComparator().compare(key, offset,
>             length, bb.array(), bb.arrayOffset(), bb.limit());
> {code}
> {{getKey()}} creates to ByteBuffers in ScannerV2 and makes a deep copy of the key in
EncodedScannerV2.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message