hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9807) block encoder unnecessarily copies the key for each reseek
Date Fri, 25 Oct 2013 23:58:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805846#comment-13805846
] 

Hudson commented on HBASE-9807:
-------------------------------

SUCCESS: Integrated in hbase-0.96-hadoop2 #102 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/102/])
HBASE-9807 block encoder unnecessarily copies the key for each reseek (larsh: rev 1535782)
* /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
* /hbase/branches/0.96/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DataBlockEncoder.java
* /hbase/branches/0.96/hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeSeeker.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java


> block encoder unnecessarily copies the key for each reseek
> ----------------------------------------------------------
>
>                 Key: HBASE-9807
>                 URL: https://issues.apache.org/jira/browse/HBASE-9807
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.98.0, 0.94.13, 0.96.1
>
>         Attachments: 9807-0.94.txt, 9807-0.94-v2.txt, 9807-0.94-v3.txt, 9807-trunk-v1.txt
>
>
> In HFileReaderV2.AbstractScannerV2.reseekTo(...) we have this:
> {code}
>         ByteBuffer bb = getKey();
>         compared = reader.getComparator().compare(key, offset,
>             length, bb.array(), bb.arrayOffset(), bb.limit());
> {code}
> {{getKey()}} creates two ByteBuffers in ScannerV2 and makes a deep copy of the key in
EncodedScannerV2.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message