hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Zhong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9793) Offline a region before it's closed could cause double assignment
Date Thu, 17 Oct 2013 18:26:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798232#comment-13798232
] 

Jeffrey Zhong commented on HBASE-9793:
--------------------------------------

I reviewed the patch. One minor thing is that we should remove the following code. The rest
looks good for me. It'll be better if you have a successful IT run before to check in. Thanks.
{code}
+        if (server.isStopped() || server.isAborted()) {
+          LOG.info("Skip assigning " + region.getRegionNameAsString()
+            + ", the server is stopped/aborted");
+        }
{code}

Because we have in the assign as following. You can add the check  server.isAborted() though
in the loop condition.

{code}
  for (int i = 1; i <= maximumAttempts && !server.isStopped(); i++) {
{code}

> Offline a region before it's closed could cause double assignment
> -----------------------------------------------------------------
>
>                 Key: HBASE-9793
>                 URL: https://issues.apache.org/jira/browse/HBASE-9793
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: trunk-9793.patch
>
>
> The fix for HBASE-9773 could cause double assignment, as [~jeffreyz] pointed out. Let's
fix it in a separate jira instead of an addendum since there are different opinions on how
to fix it.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message