hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-9754) Consider eliminating threadlocals from MVCC code
Date Thu, 17 Oct 2013 15:03:44 GMT

     [ https://issues.apache.org/jira/browse/HBASE-9754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated HBASE-9754:
--------------------------

    Attachment: 9754-rp-hregion-v2.txt

Good point, Chunhui.

In latest patch, I refactored Compactor#createFileScanners() and Compactor#setSmallestReadPoint()
which are called by DefaultCompactor#compact().

Now store.getSmallestReadPoint() is only called once.

> Consider eliminating threadlocals from MVCC code
> ------------------------------------------------
>
>                 Key: HBASE-9754
>                 URL: https://issues.apache.org/jira/browse/HBASE-9754
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Ted Yu
>             Fix For: 0.98.0
>
>         Attachments: 9754-rp-0.txt, 9754-rp-1.txt, 9754-rp-hregion.txt, 9754-rp-hregion-v2.txt
>
>
> Brought up by [~vrodionov] and [~yuzhihong@gmail.com].
> Currently we use ThreadLocals to communicate the current readpoint between a RegionScanner
and the Store\{File}Scanner's down the stack.
> Since ThreadLocals are not cheap we should consider whether it is possible to pass the
readpoint through the call stack instead.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message