hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9648) collection one expired storefile causes it to be replaced by another expired storefile
Date Wed, 02 Oct 2013 14:58:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784040#comment-13784040
] 

Jean-Marc Spaggiari commented on HBASE-9648:
--------------------------------------------

Ok. For the test, I see. We are testing it, but it's working as expected. We creates 4 files
which are not empty and we try to compact them. We don't have the corner case where those
files are empty, and when there is only one single file in the store, etc.

So if I take the test from your patch but not the rest, it should be failing, right? Overall
the patch looks good. There is some small things but we will keep that for the final version
;)

> collection one expired storefile causes it to be replaced by another expired storefile
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-9648
>                 URL: https://issues.apache.org/jira/browse/HBASE-9648
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Jean-Marc Spaggiari
>         Attachments: HBASE-9648.patch, HBASE-9648-v0-0.94.patch, HBASE-9648-v0-trunk.patch,
HBASE-9648-v1-trunk.patch
>
>
> There's a shortcut in compaction selection that causes the selection of expired store
files to quickly delete.
> However, there's also the code that ensures we write at least one file to preserve seqnum.
This new empty file is "expired", because it has no data, presumably.
> So it's collected again, etc.
> This affects 94, probably also 96.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message