Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 26 Sep 2013 20:30:04 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12670629.1380168575610.26250.1380227404736@arcas>
In-Reply-To: <JIRA.12670629.1380168575610@arcas>
References: <JIRA.12670629.1380168575610@arcas>
Subject: [jira] [Commented] (HBASE-9661) Consistent log severity level
 guards and statements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779188#comment-13779188 ] 

Hudson commented on HBASE-9661:
-------------------------------

FAILURE: Integrated in HBase-TRUNK #4564 (See [https://builds.apache.org/job/HBase-TRUNK/4564/])
HBASE-9661 Consistent log severity level guards and statements (Jackie Chang) (jmhsieh: rev 1526620)
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java

                
> Consistent log severity level guards and statements 
> ----------------------------------------------------
>
>                 Key: HBASE-9661
>                 URL: https://issues.apache.org/jira/browse/HBASE-9661
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.95.2
>            Reporter: Jackie Chang
>            Assignee: Jackie Chang
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.0
>
>         Attachments: HBASE-9661.patch
>
>
> A log statement should be guarded by its matching severity level. A log statement like
>      if (LOG.isTraceEnabled()) {
>        LOG.debug(identifier + " opening connection to ZooKeeper ensemble=" + ensemble);
> doesn't make much sense because the log message is only printed out when TRACE-level is enabled. This inconsistency was possibly introduced when developers demoted the original log statement from DEBUG but forgot to change its corresponding log severity level.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira