Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 23 Sep 2013 13:03:07 +0000 (UTC)
From: "Nicolas Liochon (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12670051.1379941224237.2486.1379941387539@arcas>
In-Reply-To: <JIRA.12670051.1379941224237@arcas>
References: <JIRA.12670051.1379941224237@arcas>
Subject: [jira] [Updated] (HBASE-9633) Partial reverse of HBASE-9533
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/HBASE-9633?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Liochon updated HBASE-9633:
-----------------------------------

    Description:=20
I don't understand the solution in HBASE-9533
In netty 3.3, they changed the group id, if I understand well for legal rea=
sons see https://github.com/netty/netty/issues/103). But they have not chan=
ged the java package name: it's still org.jboss.netty. So we should not hav=
e to remove our dependency to netty 3.6.=20

So:
- this comment is wrong imho: the explicit load is not related to the packa=
ge name but to how mapreduce load work.
{code}
+      // This is ugly.  Our zk3.4.5 depends on the org.jboss.netty, not ha=
doops io.netty
+      // so need to load it up explicitly while on 3.4.5 zk
{code}
- We do use Netty (for the multicast message), so now we're have a missing =
dependency, as maven says:
{code}
 [INFO] =E2=80=94 maven-dependency-plugin:2.1:analyze (default-cli) @ hbase=
-client =E2=80=94
[WARNING] Used undeclared dependencies found:
[WARNING] org.jboss.netty:netty:jar:3.2.2.Final:compile
{code}

So I propose a partial reverse. [~saint.ack@gmail.com], @Aleksandr S would =
it work for you?

  was:
I don't understand the solution in HBASE-9533
In netty 3.3, they changed the group id, if I understand well for legal rea=
sons see https://github.com/netty/netty/issues/103). But they have not chan=
ged the java package name: it's still org.jboss.netty. So we should not hav=
e to remove our dependency to netty 3.6.=20

So:
- this comment is wrong imho: the explicit load is not related to the packa=
ge name but to how mapreduce load work.
{code}
+      // This is ugly.  Our zk3.4.5 depends on the org.jboss.netty, not ha=
doops io.netty
+      // so need to load it up explicitly while on 3.4.5 zk
{code}
- We do use Netty (for the multicast message), so now we're have a missing =
dependency, as maven says:
{code}
 [INFO] =E2=80=94 maven-dependency-plugin:2.1:analyze (default-cli) @ hbase=
-client =E2=80=94
[WARNING] Used undeclared dependencies found:
[WARNING] org.jboss.netty:netty:jar:3.2.2.Final:compile
{code}

So I propose a partial reverse. [~saint.ack@gmail.com], would it work for y=
ou?

   =20
> Partial reverse of HBASE-9533
> -----------------------------
>
>                 Key: HBASE-9633
>                 URL: https://issues.apache.org/jira/browse/HBASE-9633
>             Project: HBase
>          Issue Type: Bug
>          Components: build, Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>             Fix For: 0.96.1
>
>         Attachments: 9633.v1.patch
>
>
> I don't understand the solution in HBASE-9533
> In netty 3.3, they changed the group id, if I understand well for legal r=
easons see https://github.com/netty/netty/issues/103). But they have not ch=
anged the java package name: it's still org.jboss.netty. So we should not h=
ave to remove our dependency to netty 3.6.=20
> So:
> - this comment is wrong imho: the explicit load is not related to the pac=
kage name but to how mapreduce load work.
> {code}
> +      // This is ugly.  Our zk3.4.5 depends on the org.jboss.netty, not =
hadoops io.netty
> +      // so need to load it up explicitly while on 3.4.5 zk
> {code}
> - We do use Netty (for the multicast message), so now we're have a missin=
g dependency, as maven says:
> {code}
>  [INFO] =E2=80=94 maven-dependency-plugin:2.1:analyze (default-cli) @ hba=
se-client =E2=80=94
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.jboss.netty:netty:jar:3.2.2.Final:compile
> {code}
> So I propose a partial reverse. [~saint.ack@gmail.com], @Aleksandr S woul=
d it work for you?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira