Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 19 Sep 2013 19:57:54 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12669517.1379618551064.164026.1379620674986@arcas>
In-Reply-To: <JIRA.12669517.1379618551064@arcas>
References: <JIRA.12669517.1379618551064@arcas>
Subject: [jira] [Commented] (HBASE-9584) Short-Circuit Coprocessor doesn't
 correctly lookup table when on server
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772221#comment-13772221 ] 

Ted Yu commented on HBASE-9584:
-------------------------------

lgtm
{code}
+    if ((isa == null ? false : checkRemote(isa.getHostName(), isa.getPort()))
{code}
Can you make the above a little easier to read ?
                
> Short-Circuit Coprocessor doesn't correctly lookup table when on server
> -----------------------------------------------------------------------
>
>                 Key: HBASE-9584
>                 URL: https://issues.apache.org/jira/browse/HBASE-9584
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>         Attachments: hbase-9584-v0.patch
>
>
> If the coprocessor isn't on the server hosting root/meta/the target HTable, it will fall back to doing the usual HConnection lookup. 
> However, that call then calls the overloaded getHRegionConnection methods, which HBASE-9534 previously made unsupported for Coprocessors. The initial idea was to limit the number of paths that we could lookup a region, but it was just incorrectly done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira