Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D1FE10782 for ; Mon, 16 Sep 2013 18:19:02 +0000 (UTC) Received: (qmail 13111 invoked by uid 500); 16 Sep 2013 18:18:56 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 12843 invoked by uid 500); 16 Sep 2013 18:18:54 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12761 invoked by uid 99); 16 Sep 2013 18:18:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 18:18:52 +0000 Date: Mon, 16 Sep 2013 18:18:52 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9503) minor optimization for getRowKeyAtOrBefore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768569#comment-13768569 ] Sergey Shelukhin commented on HBASE-9503: ----------------------------------------- Hmm, now that I think of it I am not even sure how this thing works with respect to deletes. It would seem that you always need to check all files in case of out-of-order ts-es moreover, when we look at individual scanners we are not processing deletes correctly. It might only be working because it's used on meta, so there's no timestamp magic going on and the updates are not that frequent. Wdyt? > minor optimization for getRowKeyAtOrBefore > ------------------------------------------ > > Key: HBASE-9503 > URL: https://issues.apache.org/jira/browse/HBASE-9503 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 0.98.0, 0.95.2, 0.94.12, 0.96.1 > Reporter: Liang Xie > Assignee: Liang Xie > Attachments: HBASE-9503.txt, HBASE-9503-v2.txt > > > we could shortcut the getRowKeyAtOrBefore() as quick as we found an exact matching. it'll be reasonable if there're lots of target storefiles. > It's a minor change, w/o a new test case be made:) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira