Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49D0510B04 for ; Wed, 11 Sep 2013 23:24:52 +0000 (UTC) Received: (qmail 45619 invoked by uid 500); 11 Sep 2013 23:24:52 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 45544 invoked by uid 500); 11 Sep 2013 23:24:52 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 45534 invoked by uid 99); 11 Sep 2013 23:24:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2013 23:24:52 +0000 Date: Wed, 11 Sep 2013 23:24:51 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9495) Sanity check visiblity and audience for hbase-client and hbase-common apis. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764942#comment-13764942 ] stack commented on HBASE-9495: ------------------------------ Should an abstract class be public/stable? ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractClientScanner.java This probably should not be public/stable; I can't see how they would be used by someone outside of hbase: ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingCallable.java ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java ./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java This are internals too and probably should be hidden.. not let out: ./hbase-client/src/main/java/org/apache/hadoop/hbase/util/Sleeper.java ./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Classes.java ./hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java ./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Methods.java ./hbase-common/src/main/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java ./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Strings.java ./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java > Sanity check visiblity and audience for hbase-client and hbase-common apis. > --------------------------------------------------------------------------- > > Key: HBASE-9495 > URL: https://issues.apache.org/jira/browse/HBASE-9495 > Project: HBase > Issue Type: Sub-task > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > > This is a task to audit and enumerate places where hbase-common and hbase-client should narrow or widen the exposed user program supported api. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira