Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C3F81031E for ; Fri, 6 Sep 2013 01:33:52 +0000 (UTC) Received: (qmail 91509 invoked by uid 500); 6 Sep 2013 01:33:51 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 91455 invoked by uid 500); 6 Sep 2013 01:33:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 91446 invoked by uid 99); 6 Sep 2013 01:33:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Sep 2013 01:33:51 +0000 Date: Fri, 6 Sep 2013 01:33:51 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-9445) Snapshots should create column family dirs for empty regions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-9445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759749#comment-13759749 ] Enis Soztutar commented on HBASE-9445: -------------------------------------- bq. could you explain why you need the extra family directories? just to match the /hbase/table layout? (which doesn't have the family dir until after the region is opened) We are already replicating the structure of the table directory inside the snapshot, and since those family directories are getting created for stores that have hfiles in them, we should be consistent. Since this only affects stores with no data, I don't expect extra calls to NN would justify not creating the directories. > Snapshots should create column family dirs for empty regions > ------------------------------------------------------------ > > Key: HBASE-9445 > URL: https://issues.apache.org/jira/browse/HBASE-9445 > Project: HBase > Issue Type: Bug > Components: snapshots > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 0.98.0, 0.96.0 > > Attachments: hbase-9445_v1.patch, hbase-9445_v2.patch > > > Currently, taking a snapshot will not create the family directory under a region if the family does not have any files in it. > Subsequent verification fails because of this. There is some logic in the SnapshotTestingUtils.confirmSnapshotValid() to deal with empty family directories, but I think we should create the family directories regardless of whether there are any hfiles referencing them. > {code} > 2013-09-05 11:07:21,566 DEBUG [Thread-208] util.FSUtils(1687): |-data/ > 2013-09-05 11:07:21,567 DEBUG [Thread-208] util.FSUtils(1687): |----default/ > 2013-09-05 11:07:21,568 DEBUG [Thread-208] util.FSUtils(1687): |-------test/ > 2013-09-05 11:07:21,569 DEBUG [Thread-208] util.FSUtils(1687): |----------.tabledesc/ > 2013-09-05 11:07:21,570 DEBUG [Thread-208] util.FSUtils(1690): |-------------.tableinfo.0000000001 > 2013-09-05 11:07:21,570 DEBUG [Thread-208] util.FSUtils(1687): |----------.tmp/ > 2013-09-05 11:07:21,571 DEBUG [Thread-208] util.FSUtils(1687): |----------accd6e55887057888de758df44dacda7/ > 2013-09-05 11:07:21,572 DEBUG [Thread-208] util.FSUtils(1690): |-------------.regioninfo > 2013-09-05 11:07:21,572 DEBUG [Thread-208] util.FSUtils(1687): |-------------fam/ > 2013-09-05 11:07:21,555 DEBUG [Thread-208] util.FSUtils(1687): |-.hbase-snapshot/ > 2013-09-05 11:07:21,556 DEBUG [Thread-208] util.FSUtils(1687): |----.tmp/ > 2013-09-05 11:07:21,557 DEBUG [Thread-208] util.FSUtils(1687): |----offlineTableSnapshot/ > 2013-09-05 11:07:21,558 DEBUG [Thread-208] util.FSUtils(1690): |-------.snapshotinfo > 2013-09-05 11:07:21,558 DEBUG [Thread-208] util.FSUtils(1687): |-------.tabledesc/ > 2013-09-05 11:07:21,558 DEBUG [Thread-208] util.FSUtils(1690): |----------.tableinfo.0000000001 > 2013-09-05 11:07:21,559 DEBUG [Thread-208] util.FSUtils(1687): |-------.tmp/ > 2013-09-05 11:07:21,559 DEBUG [Thread-208] util.FSUtils(1687): |-------accd6e55887057888de758df44dacda7/ > 2013-09-05 11:07:21,560 DEBUG [Thread-208] util.FSUtils(1690): |----------.regioninfo > {code} > I think this is important for 0.96.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira