Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 5 Sep 2013 13:54:52 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12667044.1378359135705.85151.1378389292845@arcas>
In-Reply-To: <JIRA.12667044.1378359135705@arcas>
References: <JIRA.12667044.1378359135705@arcas>
Subject: [jira] [Commented] (HBASE-9442) HLogKey(walKey) constructor needs
 to be either removed, deprecated or fixed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759079#comment-13759079 ] 

Hadoop QA commented on HBASE-9442:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12601606/9442.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 hadoop1.0{color}.  The patch failed to compile against the hadoop 1.0 profile.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7051//console

This message is automatically generated.
                
> HLogKey(walKey) constructor needs to be either removed, deprecated or fixed
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-9442
>                 URL: https://issues.apache.org/jira/browse/HBASE-9442
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: Roman Shaposhnik
>         Attachments: 9442.txt
>
>
> It is currently impossible to use HLogKey(walKey) because of the NPE that occurs due to constructor itself not initializing clusterIds but instead immediately calling readFieldsFromPb which then references it:
>    https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java#L475

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira