Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 60EEE10D49 for ; Tue, 10 Sep 2013 12:56:54 +0000 (UTC) Received: (qmail 16414 invoked by uid 500); 10 Sep 2013 12:56:53 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 16049 invoked by uid 500); 10 Sep 2013 12:56:53 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 15818 invoked by uid 99); 10 Sep 2013 12:56:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Sep 2013 12:56:52 +0000 Date: Tue, 10 Sep 2013 12:56:52 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8930) Filter evaluates KVs outside requested columns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8930?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1376= 3014#comment-13763014 ]=20 Hudson commented on HBASE-8930: ------------------------------- SUCCESS: Integrated in hbase-0.96-hadoop2 #15 (See [https://builds.apache.o= rg/job/hbase-0.96-hadoop2/15/]) HBASE-8930 REAPPLY with testfix (larsh: rev 1521355) * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/r= egionserver/ColumnTracker.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/r= egionserver/ExplicitColumnTracker.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/r= egionserver/ScanQueryMatcher.java * /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/r= egionserver/ScanWildcardColumnTracker.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/f= ilter/TestInvocationRecordFilter.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/r= egionserver/TestExplicitColumnTracker.java * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/r= egionserver/TestScanWildcardColumnTracker.java =20 > Filter evaluates KVs outside requested columns > ---------------------------------------------- > > Key: HBASE-8930 > URL: https://issues.apache.org/jira/browse/HBASE-8930 > Project: HBase > Issue Type: Bug > Components: Filters > Affects Versions: 0.94.7 > Reporter: Federico Gaule > Assignee: Vasu Mariyala > Priority: Critical > Labels: filters, hbase, keyvalue > Fix For: 0.98.0, 0.94.12, 0.96.1 > > Attachments: 0.94-HBASE-8930.patch, 0.94-HBASE-8930-rev1.patch, 0= .94-HBASE-8930-rev2.patch, 0.94-Independent-Test-Execution.patch, 0.95-HBAS= E-8930.patch, 0.95-HBASE-8930-rev1.patch, 0.96-HBASE-8930-rev2.patch, 0.96-= HBASE-8930-rev3.patch, 0.96-trunk-Independent-Test-Execution.patch, 8930-0.= 94.txt, HBASE-8930.patch, HBASE-8930-rev1.patch, HBASE-8930-rev2.patch, HBA= SE-8930-rev3.patch, HBASE-8930-rev4.patch, HBASE-8930-rev5.patch, HBASE-893= 0-rev6.patch > > > 1- Fill row with some columns > 2- Get row with some columns less than universe - Use filter to print kvs > 3- Filter prints not requested columns > Filter (AllwaysNextColFilter) always return ReturnCode.INCLUDE_AND_NEXT_C= OL and prints KV's qualifier > SUFFIX_0 =3D 0 > SUFFIX_1 =3D 1 > SUFFIX_4 =3D 4 > SUFFIX_6 =3D 6 > P=3D Persisted > R=3D Requested > E=3D Evaluated > X=3D Returned > | 5580 | 5581 | 5584 | 5586 | 5590 | 5591 | 5594 | 5596 | 5600 | 5601 | 5= 604 | 5606 |...=20 > | | P | P | | | P | P | | | P | = P | |... > | | R | R | R | | R | R | R | | | = | |... > | | E | E | | | E | E | | | {color:= red}E{color} | | |... > | | X | X | | | X | X | | | | = | | > {code:title=3DExtraColumnTest.java|borderStyle=3Dsolid} > @Test > public void testFilter() throws Exception { > Configuration config =3D HBaseConfiguration.create(); > config.set("hbase.zookeeper.quorum", "myZK"); > HTable hTable =3D new HTable(config, "testTable"); > byte[] cf =3D Bytes.toBytes("cf"); > byte[] row =3D Bytes.toBytes("row"); > byte[] col1 =3D new QualifierConverter().objectToByteArray(new Qu= alifier((short) 558, (byte) SUFFIX_1)); > byte[] col2 =3D new QualifierConverter().objectToByteArray(new Qu= alifier((short) 559, (byte) SUFFIX_1)); > byte[] col3 =3D new QualifierConverter().objectToByteArray(new Qu= alifier((short) 560, (byte) SUFFIX_1)); > byte[] col4 =3D new QualifierConverter().objectToByteArray(new Qu= alifier((short) 561, (byte) SUFFIX_1)); > byte[] col5 =3D new QualifierConverter().objectToByteArray(new Qu= alifier((short) 562, (byte) SUFFIX_1)); > byte[] col6 =3D new QualifierConverter().objectToByteArray(new Qu= alifier((short) 563, (byte) SUFFIX_1)); > byte[] col1g =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 558, (byte) SUFFIX_6)); > byte[] col2g =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 559, (byte) SUFFIX_6)); > byte[] col1v =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 558, (byte) SUFFIX_4)); > byte[] col2v =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 559, (byte) SUFFIX_4)); > byte[] col3v =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 560, (byte) SUFFIX_4)); > byte[] col4v =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 561, (byte) SUFFIX_4)); > byte[] col5v =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 562, (byte) SUFFIX_4)); > byte[] col6v =3D new QualifierConverter().objectToByteArray(new Q= ualifier((short) 563, (byte) SUFFIX_4)); > // =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D INSERTION =3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D// > Put put =3D new Put(row); > put.add(cf, col1, Bytes.toBytes((short) 1)); > put.add(cf, col2, Bytes.toBytes((short) 1)); > put.add(cf, col3, Bytes.toBytes((short) 3)); > put.add(cf, col4, Bytes.toBytes((short) 3)); > put.add(cf, col5, Bytes.toBytes((short) 3)); > put.add(cf, col6, Bytes.toBytes((short) 3)); > hTable.put(put); > put =3D new Put(row); > put.add(cf, col1v, Bytes.toBytes((short) 10)); > put.add(cf, col2v, Bytes.toBytes((short) 10)); > put.add(cf, col3v, Bytes.toBytes((short) 10)); > put.add(cf, col4v, Bytes.toBytes((short) 10)); > put.add(cf, col5v, Bytes.toBytes((short) 10)); > put.add(cf, col6v, Bytes.toBytes((short) 10)); > hTable.put(put); > hTable.flushCommits(); > //=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DREADING=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D// > Filter allwaysNextColFilter =3D new AllwaysNextColFilter(); > Get get =3D new Get(row); > get.addColumn(cf, col1); //5581 > get.addColumn(cf, col1v); //5584 > get.addColumn(cf, col1g); //5586 > get.addColumn(cf, col2); //5591 > get.addColumn(cf, col2v); //5594 =20 > get.addColumn(cf, col2g); //5596 > =20 > get.setFilter(allwaysNextColFilter); > get.setMaxVersions(1); > System.out.println(get); > Scan scan =3D new Scan(get); > ResultScanner scanner =3D hTable.getScanner(scan); > Iterator iterator =3D scanner.iterator(); > System.out.println("SCAN"); > while (iterator.hasNext()) { > Result next =3D iterator.next(); > for (KeyValue kv : next.list()) { > System.out.println(new QualifierConverter().byteArrayToOb= ject(kv.getQualifier())); > } > } > } > } > {code} > Requested 5581 5584 5586 5591 5594 5596 > NOT REQUESTED: 5561 > Sysout Filter > {noformat} > \x00\x00\x1A\xBE\x00\x05^:\x00\x00\xA0X\x00\x00=3D\x1A/H0:\x02.\x01/13735= 77819267/Put/vlen=3D2/ts=3D2 > Qualifier{date=3D558, type=3DSUFFIX_1} > \x00\x00\x1A\xBE\x00\x05^:\x00\x00\xA0X\x00\x00=3D\x1A/H0:\x02.\x02/13735= 77819272/Put/vlen=3D2/ts=3D3 > Qualifier{date=3D558, type=3DSUFFIX_4} > \x00\x00\x1A\xBE\x00\x05^:\x00\x00\xA0X\x00\x00=3D\x1A/H0:\x02/\x01/13735= 77819267/Put/vlen=3D2/ts=3D2 > ualifier{date=3D559, type=3DSUFFIX_1} > \x00\x00\x1A\xBE\x00\x05^:\x00\x00\xA0X\x00\x00=3D\x1A/H0:\x02/\x02/13735= 77819272/Put/vlen=3D2/ts=3D3 > Qualifier{date=3D559, type=3DSUFFIX_4} > =C2=A0 > \x00\x00\x1A\xBE\x00\x05^:\x00\x00\xA0X\x00\x00=3D\x1A/H0:\x020\x01/13735= 77819267/Put/vlen=3D2/ts=3D2 > Qualifier{date=3D560, type=3DSUFFIX_1} (DATE 5601 NOT REQUESTED BUT EVALU= ATED) > {noformat} > Sysout ExtraColumnTest > {noformat} > {"timeRange":[0,9223372036854775807],"totalColumns":6,"cacheBlocks":true,= "families":{"H0":["\\x02.\\x01","\\x02.\\x02","\\x02.\\x06","\\x02/\\x01"]}= ,"maxVersions":1,"filter":"AllwaysNextColFilter","row":"\\x00\\x00\\x1A\\xB= E\\x00\\x05^:\\x00\\x00\\xA0X\\x00\\x00=3D\\x1A"} > SCAN > Qualifier{date=3D558, type=3DSUFFIX_1} > Qualifier{date=3D558, type=3DSUFFIX_4} > Qualifier{date=3D559, type=3DSUFFIX_1} > Qualifier{date=3D559, type=3DSUFFIX_4} > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs For more information on JIRA, see: http://www.atlassian.com/software/jira