Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 25 Sep 2013 02:21:02 +0000 (UTC)
From: "Sergey Shelukhin (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12656245.1372941978821.14130.1380075662692@arcas>
In-Reply-To: <JIRA.12656245.1372941978821@arcas>
References: <JIRA.12656245.1372941978821@arcas>
Subject: [jira] [Updated] (HBASE-8870) Store.needsCompaction() should
 include minFilesToCompact
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Shelukhin updated HBASE-8870:
------------------------------------

    Attachment: HBASE-8870.03.patch

Updating the patch. One test failed and needed to be fixed.
                
> Store.needsCompaction() should include minFilesToCompact
> --------------------------------------------------------
>
>                 Key: HBASE-8870
>                 URL: https://issues.apache.org/jira/browse/HBASE-8870
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 0.95.1
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HBASE-8870.03.patch, HBASE-8870.txt, HBASE-8870.txt, HBase-8870-v2.txt
>
>
> read here:
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) > minFilesToCompact;
>   }
> {code}
> imho, it should be 
> {code}
>   public boolean needsCompaction() {
>     return (storefiles.size() - filesCompacting.size()) >= minFilesToCompact;
>   }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira