Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5BB810AF6 for ; Wed, 18 Sep 2013 23:50:52 +0000 (UTC) Received: (qmail 16367 invoked by uid 500); 18 Sep 2013 23:50:52 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 16336 invoked by uid 500); 18 Sep 2013 23:50:52 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16327 invoked by uid 99); 18 Sep 2013 23:50:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Sep 2013 23:50:52 +0000 Date: Wed, 18 Sep 2013 23:50:52 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-5257) Allow INCLUDE_AND_NEXT_COL in filters and use it in ColumnPaginationFilter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-5257: ------------------------- Component/s: Performance Filters > Allow INCLUDE_AND_NEXT_COL in filters and use it in ColumnPaginationFilter > -------------------------------------------------------------------------- > > Key: HBASE-5257 > URL: https://issues.apache.org/jira/browse/HBASE-5257 > Project: HBase > Issue Type: Improvement > Components: Filters, Performance > Reporter: Lars Hofhansl > Assignee: Varun Sharma > Fix For: 0.94.3, 0.95.0 > > Attachments: 5257-0.92.addendum, 5257-trunk.txt, 5257-trunk-v2.txt, HBASE-5257-0.92.txt, HBASE-5257-0.94.txt > > > There are various usecases and filter types where evaluating the filter before version are handled either do not make sense, or make filter handling more complicated. > Also see this comment in ScanQueryMatcher: > {code} > /** > * Filters should be checked before checking column trackers. If we do > * otherwise, as was previously being done, ColumnTracker may increment its > * counter for even that KV which may be discarded later on by Filter. This > * would lead to incorrect results in certain cases. > */ > {code} > So we had Filters after the column trackers (which do the version checking), and then moved it. > Should be at the discretion of the Filter. > Could either add a new method to FilterBase (maybe excludeVersions() or something). Or have a new Filter wrapper (like WhileMatchFilter), that should only be used as outmost filter and indicates the same (maybe ExcludeVersionsFilter). > See latest comments on HBASE-5229 for motivation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira