hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9676) AsyncProcess can create more tasks than hbase.client.max.total.tasks
Date Mon, 30 Sep 2013 18:19:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782070#comment-13782070
] 

Nick Dimiduk commented on HBASE-9676:
-------------------------------------

nit vs your comment above: max total tasks is now 100 instead of 200.

{noformat}
-  private HRegionLocation findDestLocation(Row row, int numAttempt,
-                                           int posInList, boolean force,
-                                           Map<String, Boolean> regionStatus) {
+  private HRegionLocation findDestLocation(Row row, int numAttempt, int posInList) {
{noformat}

Why did you remove the 'force' option?

{noformat}
-      if (numAttempt > 3 && LOG.isDebugEnabled()) {
+      if (numAttempt > START_LOG_ERRORS_CNT && LOG.isDebugEnabled()) {
{noformat}

Nit: the new value for START_LOG_ERRORS_CNT is 4, not 3. Was this intentional?

{noformat}
+      AtomicInteger regionCnt = taskCounterPerRegion.get(encodedRegionName);
{noformat}

I see {{nbRegion}} never crossed your mind ;)

+1

> AsyncProcess can create more tasks than hbase.client.max.total.tasks
> --------------------------------------------------------------------
>
>                 Key: HBASE-9676
>                 URL: https://issues.apache.org/jira/browse/HBASE-9676
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.98.0, 0.96.0
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Critical
>             Fix For: 0.98.0, 0.96.1
>
>         Attachments: 9676.v2.patch
>
>
> hbase.client.max.total.tasks allows to control the number of tasks in progress. But when
adding tasks, we take only into account the number of tasks currently running, not the one
we're creating.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message