hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9657) Race condition in low replication checking and FSHLog#rollWriter()
Date Wed, 25 Sep 2013 20:18:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778020#comment-13778020

Nick Dimiduk commented on HBASE-9657:

As Ted alluded to in his earlier comment, I believe this manifests as the flakiness I've seen
in TestLogRolling#testLogRollOnDatanodeDeath.
> Race condition in low replication checking and FSHLog#rollWriter()
> ------------------------------------------------------------------
>                 Key: HBASE-9657
>                 URL: https://issues.apache.org/jira/browse/HBASE-9657
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Trivial
>         Attachments: 9657-v1.txt, 9657-v2.txt
> In FSHLog#syncer(), we have this comment:
> {code}
>       // TODO: preserving the old behavior for now, but this check is strange. It's not
>       //       protected by any locks here, so for all we know rolling locks might start
>       //       as soon as we enter the "if". Is this best-effort optimization check?
>       if (!this.logRollRunning) {
>         checkLowReplication();
> {code}
> The implication is that checkLowReplication() may be running when FSHLog#rollWriter()
is also running.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message