hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9630) Add thread which detects JVM pauses like HADOOP's
Date Tue, 24 Sep 2013 20:23:05 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776696#comment-13776696
] 

Nick Dimiduk commented on HBASE-9630:
-------------------------------------

Looks to me like this patch is clean:

{noformat}
$ diff /tmp/trunk/hbase-server-findbugsXml-formatted.xml /tmp/HBASE-9630/hbase-server-findbugsXml-formatted.xml
|egrep -n "bugs=|bugCount="
30:<   <FindBugsSummary alloc_mbytes="505.62" clock_seconds="92.76" cpu_seconds="215.61"
gc_seconds="8.62" num_packages="63" peak_mbytes="410.87" priority_1="18" priority_2="83" referenced_classes="3138"
timestamp="Tue, 24 Sep 2013 11:08:08 -0700" total_bugs="101" total_classes="1227" total_size="76354"
vm_version="20.12-b01-434">
32:>   <FindBugsSummary alloc_mbytes="505.62" clock_seconds="105.72" cpu_seconds="235.86"
gc_seconds="9.47" num_packages="63" peak_mbytes="418.65" priority_1="18" priority_2="83" referenced_classes="3145"
timestamp="Tue, 24 Sep 2013 11:30:23 -0700" total_bugs="101" total_classes="1231" total_size="76474"
vm_version="20.12-b01-434">
34:<     <FileStats bugCount="0" path="org/apache/hadoop/hbase/master/HMaster.java"
size="1361"></FileStats>
36:>     <FileStats bugCount="0" path="org/apache/hadoop/hbase/master/HMaster.java"
size="1366"></FileStats>
38:<     <FileStats bugCount="0" path="org/apache/hadoop/hbase/regionserver/HRegionServer.java"
size="2030"></FileStats>
40:>     <FileStats bugCount="0" path="org/apache/hadoop/hbase/regionserver/HRegionServer.java"
size="2035"></FileStats>
42:>     <FileStats bugCount="0" path="org/apache/hadoop/hbase/util/JvmPauseMonitor.java"
size="110"></FileStats>
44:<     <PackageStats package="org.apache.hadoop.hbase.master" priority_1="4" priority_2="7"
total_bugs="11" total_size="8086" total_types="88">
46:>     <PackageStats package="org.apache.hadoop.hbase.master" priority_1="4" priority_2="7"
total_bugs="11" total_size="8091" total_types="88">
48:<       <ClassStats bugs="0" class="org.apache.hadoop.hbase.master.HMaster" interface="false"
size="1303" sourceFile="HMaster.java"></ClassStats>
50:>       <ClassStats bugs="0" class="org.apache.hadoop.hbase.master.HMaster" interface="false"
size="1308" sourceFile="HMaster.java"></ClassStats>
52:<     <PackageStats package="org.apache.hadoop.hbase.regionserver" priority_2="16"
total_bugs="16" total_size="13559" total_types="182">
54:>     <PackageStats package="org.apache.hadoop.hbase.regionserver" priority_2="16"
total_bugs="16" total_size="13564" total_types="182">
56:<       <ClassStats bugs="0" class="org.apache.hadoop.hbase.regionserver.HRegionServer"
interface="false" size="1872" sourceFile="HRegionServer.java"></ClassStats>
58:>       <ClassStats bugs="0" class="org.apache.hadoop.hbase.regionserver.HRegionServer"
interface="false" size="1877" sourceFile="HRegionServer.java"></ClassStats>
60:<     <PackageStats package="org.apache.hadoop.hbase.util" priority_1="2" priority_2="4"
total_bugs="6" total_size="6251" total_types="104">
62:>     <PackageStats package="org.apache.hadoop.hbase.util" priority_1="2" priority_2="4"
total_bugs="6" total_size="6361" total_types="108">
64:>       <ClassStats bugs="0" class="org.apache.hadoop.hbase.util.JvmPauseMonitor"
interface="false" size="65" sourceFile="JvmPauseMonitor.java"></ClassStats>
65:>       <ClassStats bugs="0" class="org.apache.hadoop.hbase.util.JvmPauseMonitor$1"
interface="false" size="1" sourceFile="JvmPauseMonitor.java"></ClassStats>
66:>       <ClassStats bugs="0" class="org.apache.hadoop.hbase.util.JvmPauseMonitor$GcTimes"
interface="false" size="21" sourceFile="JvmPauseMonitor.java"></ClassStats>
67:>       <ClassStats bugs="0" class="org.apache.hadoop.hbase.util.JvmPauseMonitor$Monitor"
interface="false" size="23" sourceFile="JvmPauseMonitor.java"></ClassStats>
{noformat}
                
> Add thread which detects JVM pauses like HADOOP's
> -------------------------------------------------
>
>                 Key: HBASE-9630
>                 URL: https://issues.apache.org/jira/browse/HBASE-9630
>             Project: HBase
>          Issue Type: New Feature
>          Components: regionserver
>    Affects Versions: 0.98.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HBase-9630.txt, HBase-9630-v2.txt
>
>
> Todd adds daemon threads for dn&nn to indicate the VM or kernel caused pause in application
log, it's pretty handy for diagnose, i thought it's great to have similar ability in HBase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message