hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9598) Non thread safe increment of task.unforcedResubmits in SplitLogManager#resubmit()
Date Sat, 21 Sep 2013 04:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773724#comment-13773724
] 

ramkrishna.s.vasudevan commented on HBASE-9598:
-----------------------------------------------

Patch looks good to me.  +1
                
> Non thread safe increment of task.unforcedResubmits in SplitLogManager#resubmit()
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-9598
>                 URL: https://issues.apache.org/jira/browse/HBASE-9598
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 9598-v1.txt, 9598-v2.txt
>
>
> In SplitLogManager#resubmit():
> {code}
>     if (directive != FORCE) {
>       task.unforcedResubmits++;
>     }
> {code}
> task.unforcedResubmits is volatile but the above increment doesn't have proper synchronization.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message