hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9579) Sanity check visiblity and audience for server-side modules.
Date Fri, 20 Sep 2013 00:56:55 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772535#comment-13772535
] 

stack commented on HBASE-9579:
------------------------------

i like the cp annotation addition

+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC)

nice

Interesting making metrics private.... suppose thats fine... forces those that would read
them to go via published interfaces, jmx, etc.

THis should be private?

-@InterfaceStability.Evolving
+@InterfaceAudience.Private
 public abstract class FSUtils {

Hmmm.. I suppose this general utility... but no harm making it internal

-@InterfaceAudience.Public
+@InterfaceAudience.Private
 @InterfaceStability.Stable
 public class HashedBytes {

+1

                
> Sanity check visiblity and audience for server-side modules.
> ------------------------------------------------------------
>
>                 Key: HBASE-9579
>                 URL: https://issues.apache.org/jira/browse/HBASE-9579
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9579.patch, hbase-9579.v2.patch
>
>
> Similar to HBASE-9495 we should audit the hbase-hadoop*-compat, hbase-prefix-tree, hbase-protocol
and hbase server-modules. 
> I'll go through each module first making most things private, and then do a second pass
using some sort of LimitedPrivate marking for apis that we'd expect coprocs or advanced tests
to use.
> This is less urgent that the work for the client facing apis.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message