hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-9576) Fixups in hbase protobuf
Date Mon, 30 Sep 2013 21:32:28 GMT

     [ https://issues.apache.org/jira/browse/HBASE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-9576:

    Attachment: 9612revert096.txt

Revert from 0.96.

> Fixups in hbase protobuf
> ------------------------
>                 Key: HBASE-9576
>                 URL: https://issues.apache.org/jira/browse/HBASE-9576
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>            Reporter: stack
>         Attachments: 0001-HBASE-9576-task1.patch, 9612revert096.txt
> Benoit was looking at out pbs.  Had following remarks:
> {code}
> ...there is something that doesn't make sense to me...a MutateRequest can have a Condition...the
Condition has row/family/qualifier...so for a single KV CAS, one needs to specify the...row/family/qualifier
twice...once in the MutationProto and once in the Condition...not a huge deal...just weird
> ...also in Comparator.proto, both BinaryComparator and BinaryPrefixComparator (and BitComparator
too actually) would have been better off without ByteArrayComparable, which seems a useless
pb, but no big deal either
> {code}
> Will keep this issue open as place to accumulate pb fixups.

This message was sent by Atlassian JIRA

View raw message