hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9576) Fixups in hbase protobuf
Date Fri, 27 Sep 2013 23:22:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780562#comment-13780562

stack commented on HBASE-9576:

+1 on this patch.  Let me submit to see if it passes.  Will commit as a subtask of this issue
if all good.
> Fixups in hbase protobuf
> ------------------------
>                 Key: HBASE-9576
>                 URL: https://issues.apache.org/jira/browse/HBASE-9576
>             Project: HBase
>          Issue Type: Task
>          Components: Protobufs
>            Reporter: stack
>         Attachments: 0001-HBASE-9576-task1.patch
> Benoit was looking at out pbs.  Had following remarks:
> {code}
> ...there is something that doesn't make sense to me...a MutateRequest can have a Condition...the
Condition has row/family/qualifier...so for a single KV CAS, one needs to specify the...row/family/qualifier
twice...once in the MutationProto and once in the Condition...not a huge deal...just weird
> ...also in Comparator.proto, both BinaryComparator and BinaryPrefixComparator (and BitComparator
too actually) would have been better off without ByteArrayComparable, which seems a useless
pb, but no big deal either
> {code}
> Will keep this issue open as place to accumulate pb fixups.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message