hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9543) Impl unique aggregation
Date Tue, 24 Sep 2013 20:33:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776713#comment-13776713
] 

Jean-Marc Spaggiari commented on HBASE-9543:
--------------------------------------------

- Can you add javadoc to public void getUnique(RpcController controller, AggregateRequest
request,
- There is 2 trailing spaces tha can be remove
{code}
+    log.info("Uniqiue set size from this region is "
+        + env.getRegion().getRegionNameAsString() + ": " + colSet.size());
+    done.run(response);
+  }
+  <--- here
{code}
- Typo: "Uniqiue" should be "Unique"
- Please add "if (log.isInfoEnabled())" before the log.info to reduce the strings creation.
- I will have rephrase it like:
{code}
    log.info("Unique set size from region " + env.getRegion().getRegionNameAsString() + "
is "
        + ": " + colSet.size());
{code}

Everything else sound good to me.
                
>  Impl unique aggregation
> ------------------------
>
>                 Key: HBASE-9543
>                 URL: https://issues.apache.org/jira/browse/HBASE-9543
>             Project: HBase
>          Issue Type: New Feature
>          Components: Coprocessors
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>         Attachments: HBASE-9543-0.94-v1.diff, HBASE-9543-trunk-v1.diff
>
>
> Impl unique aggregation: return a set of all columns' values in a scan.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message