hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-9529) Audit of hbase-client @InterfaceAudience.Public apis
Date Sun, 15 Sep 2013 05:23:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767687#comment-13767687
] 

Jonathan Hsieh edited comment on HBASE-9529 at 9/15/13 5:23 AM:
----------------------------------------------------------------

A few updates
- JD says ReplicationAdmin is the only thing that should be public in the replication client
packages.
- Make ClientScannre#getScannerCallable private (it returns a ScannerCallable which should
be private)

----

No markings mean currently public and should remain public. 


Will make all of these private:
Action, ConnectionUtils, HConnectable, HTableUtil, MultiAction, MultiResponse, ScanMetrics,
ColumnInterpreter

These are currently public and will remain public:
Mutation, Operation, OperationWithAttributes

RegionState is exposed by ClusterStatus in {{public Map<String,org.apache.hadoop.hbase.master.RegionState>
getRegionsInTransition()}}.  We could open RegionState or hide just the ClusterStatus#getRegionsInTransition
method.  I lean towards keeping it exposed. 

                
      was (Author: jmhsieh):
    
A few updates
- JD says ReplicationAdmin is the only thing that should be public
- Make ClientScannre#getScannerCallable private (it returns a ScannerCallable which should
be private)

----

No markings mean currently public and should remain public. 


Will make all of these private:
Action, ConnectionUtils, HConnectable, HTableUtil, MultiAction, MultiResponse, ScanMetrics,
ColumnInterpreter

These are currently public and will remain public:
Mutation, Operation, OperationWithAttributes

RegionState is exposed by ClusterStatus in {{public Map<String,org.apache.hadoop.hbase.master.RegionState>
getRegionsInTransition()}}.  We could open RegionState or hide just the ClusterStatus#getRegionsInTransition
method.  I lean towards keeping it exposed. 

                  
> Audit of hbase-client @InterfaceAudience.Public apis
> ----------------------------------------------------
>
>                 Key: HBASE-9529
>                 URL: https://issues.apache.org/jira/browse/HBASE-9529
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jonathan Hsieh
>             Fix For: 0.98.0, 0.96.0
>
>
> Similar to HBASE-9523, let's do an audit of the hbase-client public api.  This is easier
to do now that the we can publish only the public api javadoc 
> http://hbase.apache.org/apidocs/  (notice it only has Public apis now!)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message