hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9508) Restore some API mistakenly removed in client, mapred*, and common
Date Thu, 12 Sep 2013 00:25:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765002#comment-13765002
] 

Jonathan Hsieh commented on HBASE-9508:
---------------------------------------

There was some discussion around this with [~ndimiduk] -- I think I'd prefer if the restored
methods were @deprecated. for  HRI#getTableName, HRI#GetTable, #HRI#getTableName, HTD#remove
 (the rest were marked as deprecated).

Drat, for the methods that return a TableName, getTableName would have been an ideal name.
:) getTable seems ok.  is getHTableName or getTablename better or too subtle?

With tablename as byte[] being returned and as args javadoc should say something about what
names space is being used - is it "interpreted" or is it default?  If there is old code as
presented a table name that had a ':' in it, in the past it would be rejected -- it should
be rejected here in this compat api as well.  (echos of our pow-wow discussion). 







                
> Restore some API mistakenly removed in client, mapred*, and common
> ------------------------------------------------------------------
>
>                 Key: HBASE-9508
>                 URL: https://issues.apache.org/jira/browse/HBASE-9508
>             Project: HBase
>          Issue Type: Bug
>          Components: Usability
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 0.98.0, 0.96.0
>
>         Attachments: 9508.txt, 9508v2.txt
>
>
> Here is contrib to the API compatibility story.  I went over Aleks' compatibility report
and restored removed or overriden methods and constructors, stuff that was in 0.94 non-deprecated
and removed in 0.96.
> This patch is not comprehensive because some removals cannot be restored as in those
that used take Writables (more on this later from Jon).
> The changes included here are mostly restore of methods that took a table name as a byte
array replaced by a TableName object.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message