hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9495) Sanity check visiblity and audience for hbase-client and hbase-common apis.
Date Wed, 11 Sep 2013 23:24:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764942#comment-13764942
] 

stack commented on HBASE-9495:
------------------------------

Should an abstract class be public/stable?

./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AbstractClientScanner.java

This probably should not be public/stable; I can't see how they would be used by someone outside
of hbase:

./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionServerCallable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingCallable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java


This are internals too and probably should be hidden.. not let out:

./hbase-client/src/main/java/org/apache/hadoop/hbase/util/Sleeper.java
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Classes.java
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Methods.java
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/SoftValueSortedMap.java
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Strings.java
./hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java

                
> Sanity check visiblity and audience for hbase-client and hbase-common apis.
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-9495
>                 URL: https://issues.apache.org/jira/browse/HBASE-9495
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>
> This is a task to audit and enumerate places where hbase-common and hbase-client should
narrow or widen the exposed user program supported api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message