hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9494) Cleanup inconsistencies in protobuf message and rpc names
Date Thu, 12 Sep 2013 00:38:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765013#comment-13765013
] 

Hudson commented on HBASE-9494:
-------------------------------

FAILURE: Integrated in hbase-0.96-hadoop2 #19 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/19/])
HBASE-9494 Cleanup inconsistencies in protobuf message and rpc names (stack: rev 1522037)
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* /hbase/branches/0.96/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromAdmin.java
* /hbase/branches/0.96/hbase-protocol/pom.xml
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AccessControlProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AggregateProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AuthenticationProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/FilterProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/HFileProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MapReduceProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterAdminProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterMonitorProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutation.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutationProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RowProcessorProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/SecureBulkLoadProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/Tracing.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/TracingProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/WALProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/AccessControl.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/Admin.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/Aggregate.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/Authentication.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/Client.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/ClusterStatus.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/Filter.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/HBase.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/HFile.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/MapReduce.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/MasterAdmin.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/MasterMonitor.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/MultiRowMutation.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/RPC.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/RegionServerStatus.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/RowProcessor.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/SecureBulkLoad.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/Tracing.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/WAL.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/ZooKeeper.proto
* /hbase/branches/0.96/hbase-protocol/src/main/protobuf/hbase.proto
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/RowProcessorClient.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRowProcessorEndpoint.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java
* /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java
* /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java

                
> Cleanup inconsistencies in protobuf message and rpc names
> ---------------------------------------------------------
>
>                 Key: HBASE-9494
>                 URL: https://issues.apache.org/jira/browse/HBASE-9494
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, Protobufs
>    Affects Versions: 0.96.0
>            Reporter: Dan Burkert
>            Priority: Minor
>             Fix For: 0.98.0, 0.96.0
>
>         Attachments: 9494.096.txt, HBASE-9494.2.patch, HBASE-9494.3.patch, HBASE-9494.3.patch,
HBASE-9494.3.patch, HBASE-9494.patch
>
>
> This is a minor cleanup of some inconsistencies in names of protobuf messages and rpcs.
 I ran into these while dynamically working with hbase-protocol, where it is nice to have
message and rpc names as consistent as possible.  Specifically, most of these changes are
to have the rpc name match the message names plus [Request, Response].  Changes:
> Message renames:
> AccessControlProtos.UserPermissions[Request, Response] -> GetUserPermissions[Request,
Response]
> AggregateProtos.AggregateArgument -> AggregateRequest
> AuthenticationProtos.Token[Request, Response] -> GetAuthenticationToken[Request, Response]
> AuthenticationProtos.Token[Request, Response] -> GetAuthenticationToken[Request, Response]
> MultiRowMutation.MultiMutate[Request, Response] -> MutateRows[Request, Response]
> RowProcessorProtos.RowProcessor[Request, Response] -> ProcessRowRequest[Request, Response]
> SecureBulkLoadProtos.DelegationTokenProto -> DelegationToken
> RPC renames:
> MasterAdminProtos.RunCatalogScan -> CatalogScan
> MasterAdminProtos.Snapshot -> TakeSnapshot
> MasterAdminProtos.GetCompletedSnapshots -> ListCompletedSnapshots
> RowProcessorProtos.Process -> RowProcessorProtos.ProcessRow
> Outer classname changes:
> MultiRowMutation -> MultiRowMutationProtos
> Tracing -> TracingProtos
> File renames:
> hbase.proto -> HBase.proto

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message