hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9494) Cleanup inconsistencies in protobuf message and rpc names
Date Wed, 11 Sep 2013 08:31:55 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764119#comment-13764119
] 

Hadoop QA commented on HBASE-9494:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12602519/HBASE-9494.3.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 20 new or modified
tests.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestAtomicOperation

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7144//console

This message is automatically generated.
                
> Cleanup inconsistencies in protobuf message and rpc names
> ---------------------------------------------------------
>
>                 Key: HBASE-9494
>                 URL: https://issues.apache.org/jira/browse/HBASE-9494
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, Protobufs
>    Affects Versions: 0.96.0
>            Reporter: Dan Burkert
>            Priority: Minor
>         Attachments: HBASE-9494.2.patch, HBASE-9494.3.patch, HBASE-9494.3.patch, HBASE-9494.patch
>
>
> This is a minor cleanup of some inconsistencies in names of protobuf messages and rpcs.
 I ran into these while dynamically working with hbase-protocol, where it is nice to have
message and rpc names as consistent as possible.  Specifically, most of these changes are
to have the rpc name match the message names plus [Request, Response].  Changes:
> Message renames:
> AccessControlProtos.UserPermissions[Request, Response] -> GetUserPermissions[Request,
Response]
> AggregateProtos.AggregateArgument -> AggregateRequest
> AuthenticationProtos.Token[Request, Response] -> GetAuthenticationToken[Request, Response]
> AuthenticationProtos.Token[Request, Response] -> GetAuthenticationToken[Request, Response]
> MultiRowMutation.MultiMutate[Request, Response] -> MutateRows[Request, Response]
> RowProcessorProtos.RowProcessor[Request, Response] -> ProcessRowRequest[Request, Response]
> SecureBulkLoadProtos.DelegationTokenProto -> DelegationToken
> RPC renames:
> MasterAdminProtos.RunCatalogScan -> CatalogScan
> MasterAdminProtos.Snapshot -> TakeSnapshot
> MasterAdminProtos.GetCompletedSnapshots -> ListCompletedSnapshots
> RowProcessorProtos.Process -> RowProcessorProtos.ProcessRow
> Outer classname changes:
> MultiRowMutation -> MultiRowMutationProtos
> Tracing -> TracingProtos
> File renames:
> hbase.proto -> HBase.proto

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message