hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9494) Cleanup inconsistencies in protobuf message and rpc names
Date Tue, 10 Sep 2013 22:08:52 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763599#comment-13763599
] 

stack commented on HBASE-9494:
------------------------------


Disturbing the public APIs as little as possible is probably best at this late stage in the
0.96 game... so your leaving the methods as is and changing pb to match looks good.

St.Ack 
                
> Cleanup inconsistencies in protobuf message and rpc names
> ---------------------------------------------------------
>
>                 Key: HBASE-9494
>                 URL: https://issues.apache.org/jira/browse/HBASE-9494
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC, Protobufs
>    Affects Versions: 0.96.0
>            Reporter: Dan Burkert
>            Priority: Minor
>         Attachments: HBASE-9494.patch
>
>
> This is a minor cleanup of some inconsistencies in names of protobuf messages and rpcs.
 I ran into these while dynamically working with hbase-protocol, where it is nice to have
message and rpc names as consistent as possible.  Specifically, most of these changes are
to have the rpc name match the message names plus [Request, Response].  Changes:
> Message renames:
> AccessControlProtos.UserPermissions[Request, Response] -> GetUserPermissions[Request,
Response]
> AggregateProtos.AggregateArgument -> AggregateRequest
> AuthenticationProtos.Token[Request, Response] -> GetAuthenticationToken[Request, Response]
> AuthenticationProtos.Token[Request, Response] -> GetAuthenticationToken[Request, Response]
> MultiRowMutation.MultiMutate[Request, Response] -> MutateRows[Request, Response]
> RowProcessorProtos.RowProcessor[Request, Response] -> ProcessRowRequest[Request, Response]
> SecureBulkLoadProtos.DelegationTokenProto -> DelegationToken
> RPC renames:
> MasterAdminProtos.RunCatalogScan -> CatalogScan
> MasterAdminProtos.Snapshot -> TakeSnapshot
> MasterAdminProtos.GetCompletedSnapshots -> ListCompletedSnapshots
> RowProcessorProtos.Process -> RowProcessorProtos.ProcessRow
> Outer classname changes:
> MultiRowMutation -> MultiRowMutationProtos
> Tracing -> TracingProtos
> File renames:
> hbase.proto -> HBase.proto

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message