hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Shi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9444) EncodedScannerV2#isSeeked does not behave as described in javadoc
Date Wed, 11 Sep 2013 13:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764304#comment-13764304
] 

Chao Shi commented on HBASE-9444:
---------------------------------

bq. will it be better to ask seeker whether it is being seeked to? Agree that with the current
code, checking the seeker object to not null will work. But which one will look cleaner?

I don't quite understand: in current code, the seeker is lazily initialized, so I don't have
a chance to ask it for whether been seekd. Plus that there are already several EncodedSeeker
implementations in the codebase, so I think it better not to add a new method.
                
> EncodedScannerV2#isSeeked does not behave as described in javadoc
> -----------------------------------------------------------------
>
>                 Key: HBASE-9444
>                 URL: https://issues.apache.org/jira/browse/HBASE-9444
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>            Reporter: Chao Shi
>            Priority: Minor
>         Attachments: hbase-9444.patch
>
>
> I hit this when my tool is scanning HFiles using the scanner. I found isSeeked behaves
different whether the HFiles are prefix-encoded or not.
> There is a test case in my patch that demonstrates the bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message