hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9390) coprocessors observers are not called during a recovery with the new log replay algorithm
Date Fri, 27 Sep 2013 23:16:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780556#comment-13780556
] 

stack commented on HBASE-9390:
------------------------------

bq. The reason is that we have to pass the original WALEdits in order to for us to skip replaying
individual WALEdit when preWALRestore(can only work on original WALEdit) returns true. If
we pass mutations(which are extracted from a WALEdit), we can't skip them because we can't
reconstruct the original WALEdit.

Interesting.   Maybe stick this in the release note?  It'd be good to advertise.

bq. ...so the current doBatchOp will have an extra loop to construct MultiResponse which is
eliminated from the override doBatchOp.

Makes sense.  A comment to the above effect would help the 'lost' like myself trying to figure
why two doBatchOps that are sort of similar but not really.  For the future boss.

On addendum, I'd say rather than restructure code, add commentary so that next person through
here has a fighting chance on why stuff is the way it is.

Thanks for entertaining my questions above [~jeffreyz]
                
> coprocessors observers are not called during a recovery with the new log replay algorithm
> -----------------------------------------------------------------------------------------
>
>                 Key: HBASE-9390
>                 URL: https://issues.apache.org/jira/browse/HBASE-9390
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, MTTR
>    Affects Versions: 0.95.2
>            Reporter: Nicolas Liochon
>            Assignee: Jeffrey Zhong
>         Attachments: copro.patch, hbase-9390-part2.patch, hbase-9390-part2-v2.patch,
hbase-9390.patch, hbase-9390-v2.patch
>
>
> See the patch to reproduce the issue: If we activate log replay we don't have the events
on WAL restore.
> Pinging [~jeffreyz], we discussed this offline.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message