hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-9334) Convert KeyValue to Cell in hbase-client module - Filters
Date Mon, 09 Sep 2013 14:41:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761892#comment-13761892
] 

Nicolas Liochon commented on HBASE-9334:
----------------------------------------

I may miss something obvious, but I understand that the goal of this change is to require
a recompile but not modification of the client app ("Recompile of client apps likely needed
after this change.").

But with this change:

bq. public KeyValue[] raw() { ===> public Cell[] raw() {

A client which was calling 'raw' must now be changed to use 'Cell', no?
Incidentally, it seems not possible to write a client that would work with 2 versions of HBase
(i.e. modifying the client, but beeing able to compile the modified client with a previous
version of HBase).

I'm having the issue because I port the ycsb benchmark. It depends on raw.  

Lastly, audience parameter for 'cell' is private, but as it appears in a public interface
I think it should be public...
                
> Convert KeyValue to Cell in hbase-client module - Filters
> ---------------------------------------------------------
>
>                 Key: HBASE-9334
>                 URL: https://issues.apache.org/jira/browse/HBASE-9334
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 0.95.2
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-9334.patch, hbase-9334.v2.patch, hbase-9334.v3.patch, hbase-9334.v4.patch,
hbase-9334.v6.patch
>
>
> The goal is is to remove KeyValue from the publicly exposed API and require clients to
use the cleaner mroe encapsulated Cell API instead.  For filters, this affects #filterKeyValue,
#transform, #filterrow, and #getNextKeyHint.
> Since Cell is a base interface for KeyValue, changing these means that 0.94 apps may
need a recompile but probably no modifications. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message